From a4832ca5684c4a8ed6299c91c2273d9810a99f39 Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Wed, 5 Sep 2018 18:07:30 +0300 Subject: [PATCH 1/2] fix: comparing shasums takes a lot of time Comparing the old shasums and new shasums takes a lot of time as we use find for searching in a map. Instead, just check if we have the entry we are looking for. In bigger projects (for example with more than 20 000 files including node_modules), the comparison may take more than 100 seconds, which breaks the LiveSync for Android as the socket is closed after 70 seconds without action. So, in case you have a huge project and try `tns run android`, you'll probably receive: ``` Unable to apply changes on device: 192.168.3.101:5555. Error is: Socket Error: Error: write ECONNABORTED. ``` After the change, the time for comparing 24 000 shasums is 25 ms instead of more than 100 seconds --- lib/common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/common b/lib/common index 9623764190..cc6b6fdfe8 160000 --- a/lib/common +++ b/lib/common @@ -1 +1 @@ -Subproject commit 9623764190f3d7e1e64add933d9c31cb2148704d +Subproject commit cc6b6fdfe821b01d2b79023808af18ce59b1c569 From 3ac6ddcf96d59348759cdf8b53f3cf6db56c5c57 Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Wed, 5 Sep 2018 18:09:30 +0300 Subject: [PATCH 2/2] chore: set version to 4.2.4 --- npm-shrinkwrap.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json index 51098a1a84..a9d8760b20 100644 --- a/npm-shrinkwrap.json +++ b/npm-shrinkwrap.json @@ -1,6 +1,6 @@ { "name": "nativescript", - "version": "4.2.3", + "version": "4.2.4", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index f040e592b2..b8d3b4e4c8 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "nativescript", "preferGlobal": true, - "version": "4.2.3", + "version": "4.2.4", "author": "Telerik ", "description": "Command-line interface for building NativeScript projects", "bin": {