From c0a00767c64504b18c17929d448c4c72798af7aa Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Thu, 9 Aug 2018 08:55:38 +0300 Subject: [PATCH 1/2] fix: status of iOS Sim images and Android Emulator images are different Whenever CLI returns information for available emulators/simulators, the returned object for each of the image has a status property. For Android the status is "Running" or "Not running", for iOS it is "Connected" or "Disconnected". Unify the status properties - use "Running" and "Not running" for both of the images. Also, for iOS images, the imageIdentifier property has not been populated - fill it with the value of the identifier property, so the API will be consistent for both Android and iOS. As the property has not been populated for iOS Simulators, the events "emulatorImageFound" and "emulatorImageLost" were never triggered in case you add new iOS Simulator images. Now this should work correctly. Fix unit tests on Windows - the split by EOL when parsing the output of avdmanager executable is not working on Windows, as the EOL is `\r\n`, while the avdmanager prints results with `\n` only. Also the tests were failing on Windows due to the same reason - test case has `\n`, while split is by `\r\n`. Use some constants in the tests instead of strings for status property. --- lib/common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/common b/lib/common index 5e1da68399..0405ea4eea 160000 --- a/lib/common +++ b/lib/common @@ -1 +1 @@ -Subproject commit 5e1da68399f8d9c6b1972b1fc5014d9bb63fd235 +Subproject commit 0405ea4eea768f4264ed68372e63094690371a86 From f7e2d607b79c0a46fef1aaea5b6376fb47f48f7d Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Thu, 9 Aug 2018 08:58:54 +0300 Subject: [PATCH 2/2] docs: update changelog for 4.2.1 --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a9a1afe7f9..e2e4bf3540 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,16 @@ NativeScript CLI Changelog ================ +4.2.1 (2018, August 10) +== + +### Fixed +* [Fixed #3763](https://github.com/NativeScript/nativescript-cli/issues/3763): Duplicated entries in `tns run` log while livesyncing +* [Fixed #3802](https://github.com/NativeScript/nativescript-cli/issues/3802): Unable to use templates without `App_Resources` +* [Fixed #3803](https://github.com/NativeScript/nativescript-cli/issues/3803): `tns run ios` command fails if tns-ios version is a tag +* [Fixed #3805](https://github.com/NativeScript/nativescript-cli/issues/3805): `tns run android` fails in case you do not have Android emulator images + + 4.2.0 (2018, August 7) ==