fix(prepare): disregard app_resources's dir name when preparing in platforms/ #3403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
force-pushed
the
kddimitrov/nsconfig-app-folder
branch
from
b96a8cc to
2b5ef94
Compare
petekanev
force-pushed
the
pete/nsconfig-app-folder-patch1
branch
2 times, most recently
from
a944442 to
3faf66e
Compare
rosen-vladimirov
approved these changes
Mar 2, 2018
petekanev
force-pushed
the
pete/nsconfig-app-folder-patch1
branch
from
3faf66e to
d7b244a
Compare
petekanev
changed the title
|
@KristianDD please review |
petekanev
force-pushed
the
pete/nsconfig-app-folder-patch1
branch
from
d7b244a to
883fa4a
Compare
|
run ci |
app_resources dir path. This should align the names in platforms/android across the board and prevent having to do additional checks which could report false positives for the presence of app_resources when the name of the directory is too generic.
petekanev
force-pushed
the
pete/nsconfig-app-folder-patch1
branch
from
883fa4a to
6f94b78
Compare
KristianDD
approved these changes
Mar 5, 2018
| @@ -71,7 +71,7 @@ describe("App files copy", () => { | |||
|
|
|||
| it("copies all app files but app_resources when not bundling", () => { | |||
| const updater = new CopyAppFilesUpdater([ | |||
| "file1", "dir1/file2", "App_Resources/Android/blah.png" | |||
There was a problem hiding this comment.
why is this changed? If the behavior is changed, the testname and expected results should be changed
There was a problem hiding this comment.
@rosen-vladimirov that's an oversight on my part. I changed the only failing test, because the app_resources were no longer filtered as part of the copy() method but in public updateApp() which returns void and I found no straightforward way of mocking it in order to update the test properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patches #3356
addresses #3400 and #3401