diff --git a/lib/common b/lib/common index 2811f51c91..774c5fe1a6 160000 --- a/lib/common +++ b/lib/common @@ -1 +1 @@ -Subproject commit 2811f51c912a3c3d373b2a4c1d06520079f6d490 +Subproject commit 774c5fe1a6e8036bc3bb6db0edbb1075ad85c206 diff --git a/lib/services/android-project-service.ts b/lib/services/android-project-service.ts index 6a66beccc3..bdca9896d3 100644 --- a/lib/services/android-project-service.ts +++ b/lib/services/android-project-service.ts @@ -80,7 +80,7 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject // this call will fail in case `android` is not set correctly. this.$androidToolsInfo.getPathToAndroidExecutable().wait(); - this.$androidToolsInfo.validateJavacVersion(this.$sysInfo.getSysInfo().wait().javacVersion, {showWarningsAsErrors: true}).wait(); + this.$androidToolsInfo.validateJavacVersion(this.$sysInfo.getSysInfo(path.join(__dirname, "..", "..", "package.json")).wait().javacVersion, {showWarningsAsErrors: true}).wait(); }).future()(); } diff --git a/lib/services/doctor-service.ts b/lib/services/doctor-service.ts index f016d51834..9cc8ec43d7 100644 --- a/lib/services/doctor-service.ts +++ b/lib/services/doctor-service.ts @@ -2,6 +2,7 @@ "use strict"; import {EOL} from "os"; import * as semver from "semver"; +import * as path from "path"; class DoctorService implements IDoctorService { private static MIN_SUPPORTED_POD_VERSION = "0.38.2"; @@ -13,7 +14,7 @@ class DoctorService implements IDoctorService { public printWarnings(): boolean { let result = false; - let sysInfo = this.$sysInfo.getSysInfo().wait(); + let sysInfo = this.$sysInfo.getSysInfo(path.join(__dirname, "..", "..", "package.json")).wait(); if (!sysInfo.adbVer) { this.$logger.warn("WARNING: adb from the Android SDK is not installed or is not configured properly."); diff --git a/lib/sys-info.ts b/lib/sys-info.ts index 0a7f1c47b6..6d660177cc 100644 --- a/lib/sys-info.ts +++ b/lib/sys-info.ts @@ -2,23 +2,25 @@ "use strict"; import {SysInfoBase} from "./common/sys-info-base"; +import * as path from "path"; export class SysInfo extends SysInfoBase { constructor(protected $childProcess: IChildProcess, protected $hostInfo: IHostInfo, protected $iTunesValidator: Mobile.IiTunesValidator, protected $logger: ILogger, + protected $winreg: IWinReg, private $androidToolsInfo: IAndroidToolsInfo) { - super($childProcess, $hostInfo, $iTunesValidator, $logger); + super($childProcess, $hostInfo, $iTunesValidator, $logger, $winreg); } - public getSysInfo(androidToolsInfo?: {pathToAdb: string, pathToAndroid: string}): IFuture { + public getSysInfo(pathToPackageJson: string, androidToolsInfo?: {pathToAdb: string, pathToAndroid: string}): IFuture { return ((): ISysInfoData => { let defaultAndroidToolsInfo = { pathToAdb: this.$androidToolsInfo.getPathToAdbFromAndroidHome().wait(), pathToAndroid: this.$androidToolsInfo.getPathToAndroidExecutable().wait() }; - return super.getSysInfo(androidToolsInfo || defaultAndroidToolsInfo).wait(); + return super.getSysInfo(pathToPackageJson || path.join(__dirname, "..", "package.json"), androidToolsInfo || defaultAndroidToolsInfo).wait(); }).future()(); } }