-
-
Notifications
You must be signed in to change notification settings - Fork 197
Missing App Icon #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
From @emiloberg on September 4, 2015 15:16 Looking at Images.xcassets, it's all empty: |
From @emiloberg on September 7, 2015 11:35 I manually solved this by drag 'n' dropping the icons to the placeholders in the screenshot above. However, this shouldn't really be the case, should it? Anything I can do to debug this? |
Hi @emiloberg, I'm glad you were able to resolve the problem manually. Can you reproduce the issue in a newly created project? What are the steps that you are using? I'm looking forward to hearing from you. |
I have a newly created project and have the same problem with iOS. Before I could upload my project to iTunes Connect, I had to change the "App Icons Source" from "Don't use asset catalogs" to an AppIcon asset catalog. After the AppIcon asset catalog was created I had to drag and drop, as described above. |
Sorry for taking long time. Now experiencing the same thing as @mikebranstein This is the app I'm trying to deploy: https://github.com/emiloberg/oppna-program-reklistan-app |
However, after drag n dropping images, archiving and uploading to iTunes Connect, I get an error: ITMS-90096 about missing Launch Images. This issue is solved (and the app is uploadable to iTunes Connect) by
|
what happens when you add the missing Launch-* images into app-root/app/App_Resources/iOS ? My expectation is that the CLI picks them up and adds them to the produced ipa. |
Nope, no difference :/ When in the build process should {N} pick up the resources from /app/App_Resources/iOS and put them in the right place (and maybe modify some other files if needed)? When I run |
With version I'm going to close this issue for now. Please use this new one #649 to share additional feedback. P.S. Support for Asset catalogs is logged as #683 |
Ive been dealing with this icon issue for like 3 days straight, felt like Im going crazy... surely the fix isnt to do what @emiloberg did by manually adding to the Images.xcassets? Where are we as of 2.01 and why is nothing documented, so many hours burned :/ |
@ChrisFlannagan Yeah, this isnt at all documented, and will hit every single person... I think the info.plist should just have these by default. Answer by @PeterStaev on slack fixed me His GIST Basically just specify all the icons in the infoplist and it'll work (assuming you have all the icons...) Case sensitive too btw. |
Well, I finally figured it out. If you are doing tweaks in xcode to the plist or anything else it can cause issues with the nativescript generated project so you gotta be carful. I started a fresh nativescript project, copied my core files and icons over including the 120px, then I tns prepare ios it. Also, nativescript seems to use lowercase i for a lot of icons in the plist when it needs to definitely be capital I based on how most icon generators spit out icons. |
Everything under /platforms should be considered volitile.. when you build the info.plist from App_Resources/iOS is copied down, thats the one you need to change manually... if you're doing this in xcode it's changing the platforms one and you're back in the same boat of it being potentially overwritten (on an upgrade or some other command) |
yea man, it caused me a big struggle today. I didn't change anything manually at first but I didn't have the 120px so then I tried to adjust it all manually in xcode to add the 120px icon and that screwed things up big time. |
#1868 (comment) |
@PanayotCankov one of the biggest things for me which is my mistake but caused me hours of stress is that the default icon names in NativeScript use lower case "i" where almost every mass icon generator I found uses uppercase "I" in Icon filename. |
@ChrisFlannagan Which icon generators do you use? It would be nice to list them here so we can have them in mind in future. |
@PanayotCankov I've used a few thinking they were generating wrong, but the entire time it was just they use I and not i lol http://icon.angrymarmot.org/ |
Exception I suppose being the @mikebranstein one http://nsimage.brosteins.com/Home/UploadIcon |
The correct URL for my icon generator is http://nsimage.brosteins.com. If you run into any problems, let me know. @ChrisFlannagan @PanayotCankov If you've got suggestions on improvements, please drop me a line. |
How is this still a thing? Got 120, 76, 152, 167 errors (same as in this issue, just without launchscreen).
.. but now it gives additional error while trying to publish app to app store: |
@dxshindeo after renaming the icon I would recommend to remove the platform and rebuild your project to ensure that your renamed icon is delivered to the native project. |
Ah, I figured out what I was doing wrong. I did: |
From @emiloberg on September 4, 2015 15:10
Hi,
When I'm trying to upload an app to iTunes Connect, it fails with the error message:
I've replaced all icons in App_Resources (gotten from the hello world project), and there's a 120x120 icon (named
icon-60@2x
)And this is how it looks like in Xcode, all the icons under
Resources
That being said. Notice the blue {N} icon in the bottom of the Xcode window. How did that get there? All the blue default icons have been replaced. Could it be that {N} hasn't updated the images as it should?
Copied from original issue: NativeScript/NativeScript#682
The text was updated successfully, but these errors were encountered: