-
-
Notifications
You must be signed in to change notification settings - Fork 197
Ability to ignore files from build and livesync #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is must have after we enabled transpilers. |
Let's use |
In my opinion |
I'm closing this one since we need TypeScript files for debugging purposes (these files can be excluded with |
@enchev This is not simply about transpiling and such, it is also about the fact that some editors add temporary files alongside files currently being edited. |
Hi @casp-simberg, Indeed, you are right. We had an issue with the temporary files some IDEs create and we've fixed it, so now these files are not livesynced anymore. Do you think there is some other case you'd need to exclude files from livesyncing? |
@pkoleva Not that I can think of right now. Sorry for the late response. I am interested in a way to add a filter on which kinds of files to watch. Usually this can be expressed as a RegExp or by some simpler means (filename extension, but this isn't enough in my case). Emacs, when auto-saving, creates files with the format '.#', and sometimes '##' also shows up, but I think that's a different feature. And then we have some versions which save the file with a tilde in the end (~). So the easiest way would be to allow a list of filters. For example --watch-ignore [".#", "##"], where the strings will differ depending on the approach you take I suppose, RegExp or a simpler way of matching. This was still a problem the last time I ran 'tns run android' (which I think is livesync, correct?) in my project. May have been fixed since this was before the big release. But is there a way to add the filter(s) manually? |
Another case when ignoring files will be useful:
Result will be ~1200 |
As we are now using webpack to build the application, I think this issue can be closed. Webpack includes only files required and used in the application, so we no longer have problem with filtering. |
Users should be able to setup the CLI to ignore particular files, usually ts, .d.ts, or other source files in a language that compiles to JS / CSS.
We can use the same rules, default rules and implementation code from AppBuilder CLI.
Things to consider:
appbuilder init
from existing {N} project should consume existing {N} specific ignore rules.The text was updated successfully, but these errors were encountered: