fix: quote windows command line arguments #5808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #5802
PR Checklist
What is the current behavior?
When building on windows, the new
shell: true
option doesn't escape arguments anymore, meaning that any commands that had spaces in their path would not work. This includes npm/adb/avd paths and app paths (that get passed to gradle via arguments)What is the new behavior?
We now quote every command to preserve the previous behavior.