Skip to content

fix host localhost for debug ios #5788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

vallemar
Copy link
Contributor

This solves the problem we had debugging in vscode on ios. The problem was that when an address was not set the plugin used 127.0.0.1 when forcing localhost it worked, but now I am migrating the old vscode-chrome-debug-core to vscode-cdp-proxy which uses ws below and when using the localhost address it resolves it as 127.0.0.1 and the cli does not accept the connection.
I have tried chromeDevTool and it still works with this change

@cla-bot cla-bot bot added the cla: yes label Feb 13, 2024
@vallemar vallemar changed the title fix host localhost fix host localhost for debug ios Feb 13, 2024
@rigor789
Copy link
Member

I guess it defaults to 0.0.0.0 if it's omitted, which should be fine.

@rigor789 rigor789 merged commit 280b10d into NativeScript:main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants