feat(open): Add open ios/android #5779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add open ios/android command. Generalise ios open command to cater for non standard installations. Fix open command on windows ( detach from launched process )
NathanWalker
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add open iOS/android command.
Generalize iOS open command to cater for non standard installations. Fix open command on windows ( detach from launched process )
PR Checklist
What is the current behavior?
Currently the start menu open on IOS does not deal with non standard installs of Xcode, e.g. using xcodes, this utilizes the existing services to figure out where the installation is.
On open android on windows the process is tied to the parent, so will not exit until Android Studio exits.
What is the new behavior?
Leveraged the start / open functionality to add command
ns open <ios|android>Fixed the above issues.
Fixes/Implements/Closes #5754.