feat(profiling): generate chrome compatible timeline data #5686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Profiling requires installing an external tool (
timeline-view
) and piping the output of a run command into it to generate a timeline html view.What is the new behavior?
A timeline json file is generated automatically when timeline profiling is enabled (
profiling: "timeline"
in the nativescript config). The file is saved when the run is canceled withctrl+c
. The output json can be loaded into chrome devtools -> Performance and loading the json.Commented out theSIGINT
handling override - as it prevented listening for it for writing the timeline jsons - however this might cause side effects, so a different approach might be required.For example and idle timeout, if no new traces come in within X seconds, it's automatically saved.Another approach is listening for a keypress (for examples
for "stop") and then stopping the timeline.Other...?Found a different approach by getting around the
SIGINT
prevention only when profiling.