Skip to content

fix: use correct path to emulator executable #5663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

We're checking for the sdk/tools/android instead of sdk/emulator/emulator/

What is the new behavior?

We check for sdk/emulator/emulator

@cla-bot cla-bot bot added the cla: yes label Apr 11, 2022
@edusperoni edusperoni requested a review from rigor789 July 27, 2022 09:35
Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - wondering if this changed with recent sdks, or has this always been there? 🤔

edit: this covers it

// Check https://developer.android.com/studio/releases/sdk-tools.html (25.3.0)
// Since this version of SDK tools, the emulator is a separate package.
// However the emulator executable still exists in the "tools" dir.

@rigor789 rigor789 merged commit d49b666 into NativeScript:master Jul 27, 2022
@edusperoni edusperoni deleted the fix/emulator-path branch January 13, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants