Skip to content

Fix error when printing environment verification message #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

sryze
Copy link
Contributor

@sryze sryze commented Oct 30, 2021

PR Checklist

What is the current behavior?

ns doctor android prints an error:

Cannot read property 'toLowerCase' of null

It fails because null is passed as platform to PlatformEnvironmentRequirements.getEnvVerificationMessage().

What is the new behavior?

No error

Fixes/Implements/Closes #[Issue Number].

@cla-bot
Copy link

cla-bot bot commented Oct 30, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @sryze.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@sryze
Copy link
Contributor Author

sryze commented Oct 30, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Oct 30, 2021
@cla-bot
Copy link

cla-bot bot commented Oct 30, 2021

The cla-bot has been summoned, and re-checked this pull request!

@sryze sryze force-pushed the doctor-android-fix branch from e5ebad0 to a630c15 Compare October 30, 2021 05:38
The `ns doctor android` command was failing because null was being passed as
`platform` to `PlatformEnvironmentRequirements.getEnvVerificationMessage()`
@sryze sryze force-pushed the doctor-android-fix branch from a630c15 to 8d5982f Compare October 30, 2021 05:39
@rigor789 rigor789 added this to the 8.2 milestone Nov 23, 2021
@rigor789 rigor789 merged commit 0be52e9 into NativeScript:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants