Skip to content

fix(ios-publish): accept body on http post and update to new api #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

jcassidyav
Copy link
Contributor

PR Checklist

What is the current behavior?

With 8.1 cli ns publish ios resulted in 401
In previous cli versions it resulted in 404 because the endpoint for changing the team was removed by apple.

What is the new behavior?

ns publish ios --appleApplicationSpecificPassword ...
ns appstore

now both work.

Fixes/Implements/Closes #5553.

@cla-bot cla-bot bot added the cla: yes label Sep 28, 2021
Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just small change to simplify logic in http-client

@rigor789 rigor789 merged commit 63acaa6 into NativeScript:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iTunesConnect API needs to be updated
2 participants