Skip to content

Xml merge doesn't work correctly #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fatme opened this issue Jun 11, 2015 · 4 comments
Closed

Xml merge doesn't work correctly #555

Fatme opened this issue Jun 11, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@Fatme
Copy link
Contributor

Fatme commented Jun 11, 2015

Steps to reproduce:

  1. Create a plugin that contains for example  AndroidManifest.xml and adds some permissions
  2. Add the plugin
  3. Add android platform.
  4. Ensure that the produced AndroidManifest in platforms/android is correct and contains the added permissions from step 1.
@Fatme Fatme added the bug label Jun 11, 2015
@Fatme Fatme self-assigned this Jun 11, 2015
@Fatme Fatme added this to the 1.1.1 milestone Jun 11, 2015
@Fatme Fatme mentioned this issue Jun 11, 2015
@EddyVerbruggen
Copy link
Contributor

Hi,

Ran into this as well, @Fatme did the generated xml file simply get replaced by the one provided in the plugin?

I'm curious: is there a way to make the merge work with 1.1.0 on Android at all?

@EddyVerbruggen
Copy link
Contributor

Confimed it works fine with 1.1.1 👍

Merging an <activity> doesn't however :(

@Fatme
Copy link
Contributor Author

Fatme commented Jun 19, 2015

Hi @EddyVerbruggen,

Can you send us the Manifest that you're trying to merge?

@EddyVerbruggen
Copy link
Contributor

Yep, I've tried:

<application>
    <activity
        android:name="com.google.zxing.client.android.CaptureActivity"
        android:clearTaskOnLaunch="true"
        android:configChanges="orientation|keyboardHidden"
        android:theme="@android:style/Theme.NoTitleBar.Fullscreen"
        android:windowSoftInputMode="stateAlwaysHidden"
        android:exported="false">
      <intent-filter>
        <action android:name="com.google.zxing.client.android.SCAN"/>
        <category android:name="android.intent.category.DEFAULT"/>
      </intent-filter>
    </activity>
</application>

and

    <activity
        android:name="com.google.zxing.client.android.CaptureActivity"
        android:clearTaskOnLaunch="true"
        android:configChanges="orientation|keyboardHidden"
        android:theme="@android:style/Theme.NoTitleBar.Fullscreen"
        android:windowSoftInputMode="stateAlwaysHidden"
        android:exported="false">
      <intent-filter>
        <action android:name="com.google.zxing.client.android.SCAN"/>
        <category android:name="android.intent.category.DEFAULT"/>
      </intent-filter>
    </activity>

In both cases this block is added outside the main <application> tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants