perf: initialize project data if needed #5478

janoshrubos · 2021-01-19T10:02:39Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

projectData gets re-initialized over and over again and the cache has no effect.

Initialize projectData only if it hasn't been initialized yet.

Fixes #5398

lib/services/project-data-service.ts

perf: initialize project data if needed

0988626

cla-bot bot added the cla: yes label Jan 19, 2021

rigor789 approved these changes Jan 19, 2021

View reviewed changes

rigor789 requested changes Jan 26, 2021

View reviewed changes

lib/services/project-data-service.ts Outdated Show resolved Hide resolved

janoshrubos added 3 commits January 26, 2021 20:13

refactor: move validation to initializeProjectData

50827e1

refactor: check initialization in the beginning of initializeProjectData

4b06d45

fix: negate type-o fix

dea3a02

rigor789 approved these changes Jan 27, 2021

View reviewed changes

rigor789 merged commit 27c2f0c into NativeScript:master Jan 27, 2021