Skip to content

fix: default appPath in new project #5466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

janoshrubos
Copy link
Contributor

PR Checklist

What is the current behavior?

After creating a new project based on a template, we write the default config. In some cases, the appPath is different for a template.

What is the new behavior?

Default config writes appPath based on what folder exists in the template project.
Possible appPaths: app, src.

Fixes #5465

@cla-bot cla-bot bot added the cla: yes label Jan 12, 2021
Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rigor789 rigor789 linked an issue Jan 18, 2021 that may be closed by this pull request
@rigor789 rigor789 merged commit 0675896 into NativeScript:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli v 7.1.2 fresh projects broken ns create Missing or incorrect appPath for freshly created projects
2 participants