fix: CFBundleName cannot be changed

[janoshrubos]

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
• Tests for the changes are included.

What is the current behavior?

After changing CFBundleName in Info.plist, the app is built, but can't be installed because of missing .ipa file.

What is the new behavior?

App is built, installed and started, respecting the CFBundleName.

Fixes #5424

[rigor789]

This looks lika a reasonable fix to me - however I wonder if this is ever called before any .ipa exists in the output folder - in those cases, this might fail.

Does running a custom CFBundleName on device work after running ns clean in a project? That would likely be sufficient to confirm if this will work or not!

Perhaps we could fall back to ${projectData.projectName}.ipa if ipaFileName is empty.

[rigor789]

Suggested change

	(directory) => path.extname(directory) === ".ipa"
	(entry) => path.extname(entry) === ".ipa"

Minor suggestion, since we are not strictly dealing with directories.

[janoshrubos]

This looks lika a reasonable fix to me - however I wonder if this is ever called before any .ipa exists in the output folder - in those cases, this might fail.

Does running a custom CFBundleName on device work after running ns clean in a project? That would likely be sufficient to confirm if this will work or not!

Perhaps we could fall back to ${projectData.projectName}.ipa if ipaFileName is empty.

After running ns clean it works well with the custom CFBundleName on device, but i like the idea to fall back with ${projectData.projectName}.ipa if ipaFileName is empty.