Skip to content

--includeAngularDemo option does not work. #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robario opened this issue Apr 14, 2020 · 1 comment
Open

--includeAngularDemo option does not work. #5297

robario opened this issue Apr 14, 2020 · 1 comment
Labels

Comments

@robario
Copy link

robario commented Apr 14, 2020

Environment

  • CLI: 6.5.0
  • Cross-platform modules: 6.2.3
  • Android Runtime: 6.2.0
  • iOS Runtime: 6.2.0
  • Plugin(s): none

Describe the bug
When tns plugin create, --includeAngularDemo option does not work.

To Reproduce

$ tns plugin create --pluginName=foo --username=bar --includeTypeScriptDemo=y --includeAngularDemo=n ./nativescript-foo

Expected behavior

$ ls ./nativescript-foo/demo-angular
ls: cannot access './nativescript-foo/demo-angular': No such file or directory

But the directory exists.

Sample project
none

Additional context
#4616

let shouldIncludeDemo = !!includeDemoOption;

At this line, includeDemoOption is "y" or "n" then shouldIncludeDemo is always true.

@robario robario changed the title https://github.com/NativeScript/nativescript-cli/issues/4616 --includeAngularDemo option does not work. Apr 14, 2020
@robario robario changed the title --includeAngularDemo option does not work. --includeAngularDemo option does not work. Apr 14, 2020
@NickIliev NickIliev added the bug label Apr 15, 2020
@NickIliev
Copy link
Contributor

@robario thanks for reporting that one - confirmed and marked it as a bug.

Workaround:: Based on the double exclamation point logic, you could just skip the flag (--includeAngularDemo) and the demo won't be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants