Skip to content

Warn if the CLI might print sensitive data to the output #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DimitarTachev opened this issue Feb 20, 2020 · 1 comment
Closed

Warn if the CLI might print sensitive data to the output #5255

DimitarTachev opened this issue Feb 20, 2020 · 1 comment
Assignees
@DimitarTachev
Labels
docs feature
Milestone
6.4.1

Comments

@DimitarTachev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The users could leak some sensitive data like secrets when they share their logs with TRACE level.

Describe the solution you'd like
We could warn them when the log level is set to TRACE

Describe alternatives you've considered
We could try to detect the secrets and replace them with * but I don't believe its possible to cover everything with regexes.

Additional context
The easiest way to leak a secret is by using it in a request query param.
@DimitarTachev DimitarTachev added this to the 6.4.1 milestone Feb 20, 2020
@DimitarTachev DimitarTachev self-assigned this Feb 20, 2020
@DimitarTachev DimitarTachev mentioned this issue Feb 20, 2020
Merged
5 tasks
@dtopuzov
Copy link
Contributor

Available in nativescript@rc, will be shipped with [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitarTachev DimitarTachev

Labels
docs feature
Projects
None yet
Milestone
6.4.1
Development

No branches or pull requests
2 participants
@DimitarTachev @dtopuzov