Skip to content

shouldMigrate can cache its result based on a hash of the package.json content. #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KristianDD opened this issue Oct 23, 2019 · 0 comments
Assignees
Milestone

Comments

@KristianDD
Copy link
Contributor

KristianDD commented Oct 23, 2019

Is your feature request related to a problem? Please describe.

shouldMigrate is executed on many commands and has a performance impact on their execution.

Describe the solution you'd like

The result of the shouldMigrate method can be cached based on the package.json content.

Describe alternatives you've considered

None

Additional context

Acceptance Criteria
Should use patch version of CLI 6.2.x
1 First tns migrate --log trace should log
Executed shouldMigrate for platforms: Android,iOS. Result is: undefined
2 Second execution should log:
Got cached result for shouldMigrate for platform: Android
Got cached result for shouldMigrate for platform: iOS
3 Change in package.json and then tns migrate --log trace should log
Executed shouldMigrate for platforms: Android,iOS. Result is: undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants