Skip to content

* Add Theme v2 name to non-external modules when starting webpack #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KristianDD opened this issue Oct 22, 2019 · 0 comments
Closed

* Add Theme v2 name to non-external modules when starting webpack #5094

KristianDD opened this issue Oct 22, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@KristianDD
Copy link
Contributor

KristianDD commented Oct 22, 2019

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI:
  • Cross-platform modules:
  • Android Runtime:
  • iOS Runtime:
  • Plugin(s):

Describe the bug

The theme v2 is considered an external package and is not included in the vendor.js file.

To Reproduce

  1. Install Preview app which includes @nativescript/theme
  2. Create an application from templates master branch
  3. tns preview android/ios
  4. scan with a device

Expected behavior
Theme v2 to be included in the vendor.js file.

Sample project

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants