Skip to content

Deprecate support for markingMode:full #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DimitarTachev opened this issue Sep 26, 2019 · 0 comments
Closed

Deprecate support for markingMode:full #5038

DimitarTachev opened this issue Sep 26, 2019 · 0 comments
Assignees
Milestone

Comments

@DimitarTachev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In the recent versions of v8 the callback we use for garbage collection is called multiple times (much more than in previous versions). During the callback execution the whole object tree is checked for links to the objects marked for release, which blocks the app. For huge apps this check may take a lot of time, during which the app freezes. As the callback is now executed much more often, some apps become unusable.

Describe the solution you'd like
The idea is to execute in the same way as we have done for webpack in 5.4 – prompt the users, who do not have set markingMode in the app/package.json. Explain them that currently they are using the markingMode: full version that is deprecated and will be removed in 7.0.0 release. Ask them if they want to use the markingMode: none, which will be the only one in 7.0.0 release or they want to keep using the markingMode: full. Persist the answer in the app/package.json file (i.e. set the value of markingMode in the app/package.json).

In consecutive commands in the same project, in case markingMode: full is set in the package.json, show a huge warning that this markingMode is deprecated and in 7.0.0 it will be removed. Ask the user to log a new issue in Android runtime repo with more details why the markingMode: full is set.

NOTE: In non-interactive terminals, in case the markingMode is not set in app/package.json, consider it as set to markingMode: full, i.e. show the warning.

Describe alternatives you've considered
Find out how to lower the calls to the garbage collection callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants