Skip to content

tns migrate should update nativescript-vue-template-compiler #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rosen-vladimirov opened this issue Jul 17, 2019 · 0 comments
Closed

tns migrate should update nativescript-vue-template-compiler #4879

rosen-vladimirov opened this issue Jul 17, 2019 · 0 comments
Assignees
Labels
bug migrate Describes issues related to migrate command
Milestone

Comments

@rosen-vladimirov
Copy link
Contributor

rosen-vladimirov commented Jul 17, 2019

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • Cross-platform modules: 5.4.0
  • Android Runtime: 5.4.0
  • iOS Runtime: 5.4.2
  • Plugin(s):
{                                                         
  "nativescript": {                                       
    "id": "org.nativescript.appVue1",                     
    "tns-android": {                                      
      "version": "5.4.0"                                  
    },                                                    
    "tns-ios": {                                          
      "version": "5.4.2"                                  
    }                                                     
  },                                                      
  "description": "NativeScript Application",              
  "license": "SEE LICENSE IN <your-license-filename>",    
  "repository": "<fill-your-repository-here>",            
  "dependencies": {                                       
    "nativescript-theme-core": "~1.0.4",                  
    "nativescript-vue": "~2.2.0",                         
    "tns-core-modules": "~5.4.0"                          
  },                                                      
  "devDependencies": {                                    
    "@babel/core": "~7.1.0",                              
    "@babel/preset-env": "~7.1.0",                        
    "babel-loader": "~8.0.0",                             
    "nativescript-dev-webpack": "~0.24.0",                
    "nativescript-vue-template-compiler": "~2.2.0",       
    "node-sass": "^4.7.1",                                
    "vue-loader": "~15.4.0"                               
  },                                                      
  "gitHead": "8c1a4866a66daab09bf5ef8e5a96472687192373",  
  "readme": "NativeScript Application"                    
}                                                         

Describe the bug
After using tns migrate for a project with Vue 2.2, nativescript-vue-template-compiler package is not updated - its still ~2.2

To Reproduce

$ tns create myApp --template [email protected]
$ cd myApp
$ tns migrate
# now check the project's package.json - `nativescript-vue-template-compiler` version is still 2.2, while it should be 2.3

Expected behavior
After migrate, the nativescript-vue-template-compiler package should be migrated. In case it is not installed in the project before calling tns migrate, the migrate command should not add it.

Additional context
WORKAROUND: npm i --save-dev nativescript-vue-template-compiler@~2.3

@rosen-vladimirov rosen-vladimirov added bug migrate Describes issues related to migrate command labels Jul 17, 2019
@rosen-vladimirov rosen-vladimirov added this to the 6.0.1 milestone Jul 17, 2019
@rosen-vladimirov rosen-vladimirov changed the title tns migrate should update nativescript-vue-compiler tns migrate should update nativescript-vue-template-compiler Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug migrate Describes issues related to migrate command
Projects
None yet
Development

No branches or pull requests

3 participants