Skip to content

Use constants instead of hardcoded android and ios strings #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DimitarTachev opened this issue Feb 25, 2019 · 0 comments
Open

Use constants instead of hardcoded android and ios strings #4388

DimitarTachev opened this issue Feb 25, 2019 · 0 comments
Labels
technical debt

Comments

@DimitarTachev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We have "android", "Android", "ANDROID" and "ios", "iOS", "IOS" hardcoded in many places in the CLI. In most of the places, we are also using platform.toLower() in order to workaround this.

Describe the solution you'd like
We should just use the same constants everywhere (e.g. DevicePlatformsConstants)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DimitarTachev