Skip to content

Angular apps do not work with HMR out of the box #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DimitarTachev opened this issue Jan 31, 2019 · 1 comment
Closed

Angular apps do not work with HMR out of the box #4325

DimitarTachev opened this issue Jan 31, 2019 · 1 comment
Assignees
@DimitarTachev @endarova
Labels
feature hmr
Milestone
5.2.0

Comments

@DimitarTachev
Copy link
Contributor

Environment

  • CLI: 5.1.1
  • Cross-platform modules: 5.1.0
  • Android Runtime: 5.1.0
  • iOS Runtime: 5.1.0
  • Plugin(s): nativescript-dev-webpack: 0.19.1

To Reproduce

  1. tns create ngApp --ng && cd ngApp
  2. tns run android --hmr or tns run ios --hmr
  3. Apply some change in order to trigger the LiveSync process.
  4. The app will not get the change applied.

Expected behavior
The app should get the change applied.

Additional context
In order to get the HMR working in Angular apps, I have to follow the steps in this wiki: https://github.com/NativeScript/nativescript-angular/wiki/HMR.
@DimitarTachev DimitarTachev added this to the 5.2.0 milestone Jan 31, 2019
@DimitarTachev DimitarTachev self-assigned this Jan 31, 2019
@endarova
Copy link
Contributor

endarova commented Jan 31, 2019 •
edited
Loading

With CLI 5.2.0 and [email protected]

  • env flag should leave your project with its current setup
  • --hmr should automatically setup your project for hmr and apply changes on device without additional snippets
  • no warning for --hmr + Angular are shown on tns run and tns debug
  • tns run --hmr should work as expected in angular projects
  • tns debug --hmr should work as expected in angular projects
  • tns preview --hmr should work as expected in angular projects
  • --hmr should work as expected in angular projects with lazy loading

@DimitarTachev DimitarTachev mentioned this issue Feb 5, 2019
Merged
5 tasks
@endarova endarova self-assigned this Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitarTachev DimitarTachev

@endarova endarova

Labels
feature hmr
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
3 participants
@DimitarTachev @endarova @rosen-vladimirov