Skip to content

Application built in release has TypeScript files #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rosen-vladimirov opened this issue Oct 10, 2018 · 0 comments
Closed

Application built in release has TypeScript files #4007

rosen-vladimirov opened this issue Oct 10, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@rosen-vladimirov
Copy link
Contributor

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 4.2.4
  • Cross-platform modules: not applicable
  • Android Runtime: not applicable
  • iOS Runtime: not applicable
  • Plugin(s): nativescript-facebook

Describe the bug
When building in release, application should not contain any TypeScript files, as they cannot be used (in debug you can use them for debugging). However, .d.ts files from plugins are included in the built app.

To Reproduce

tns create myApp
cd myApp
npm i --save nativescript-facebook
tns build android --release --keyStorePath <path> --keyStorePassword <pass> --keyStoreAlias <alias> --keyStoreAliasPassword <alias pass>
tns build ios --release --for-device

Now check the produced .apk and .ipa - they both contain .d.ts files inside <path to app>/tns_modules/nativescript-facebook.

Expected behavior
TypeScript files should not be included in the application built in release mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants