-
-
Notifications
You must be signed in to change notification settings - Fork 197
Read registry from npm config instead of hard-wiring to npmjs.org in node-package-manager #3866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
just fixed it locally, happy to open a PR, just submitted my CLA |
Hey @lambourn , thanks for reporting the issue and preparing a fix. We'll be glad to review it! |
@rosen-vladimirov no permission for me to push my branch |
Hey @lambourn ,
After that you can open your GitHub repository and create a PR - GitHub will allow you to target CLI's original repository and this way you'll create a PR in this repo. |
thanks @rosen-vladimirov - it looked as if I'd need to sign the CLA but if opening the PR from the fork works then that's also fine. |
We use artifactory as a our internal npm repository. It mirrors npmjs.org and also allow us to push internal npm packages to it.
However, when we do a clean install/build using
tns build android
the nativescript-cli itself starts a http client to pull the tns-android package from npmjs.org:nativescript-cli/lib/node-package-manager.ts
Line 123 in f0e150c
this does not work for us.
Ideally, inside the
getRegistryPackageData
the registry to use should be read from the npm config (.npmrc)The text was updated successfully, but these errors were encountered: