-
-
Notifications
You must be signed in to change notification settings - Fork 197
Podfile generation broken on livesync #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This seems to be caused by having comments in the merged podfiles as mentioned here: |
My pod file keeps getting messed up as well. Increasingly so every time I try to build. |
@rosen-vladimirov If you have a branch in progress perhaps could post it and reference this issue just so others can see movement here as it's big issue affecting many at moment. |
Hey guys, we've investigated this issue and I confirm the unexpected behavior. It can be easily reproduced by executing the following commands:
We are working on a fix and I'll write back once we have more information. |
FWIW, we are experiencing this on iOS even if you simply issue:
I believe there is no livesync when one issues a tns build (but I might be wrong). The podfile issue also occurs on repeated tns builds:
The only way around this is to remove platform, add platform, skip the prepare step and issue build directly (for every single build iteration).
|
Hey @noumaans , |
|
same for me:
|
I've done some investigation today. I've found that this problem is caused with certain combinations of plugins with Podfiles. For instance when I remove either I'm working on the issue mentioned by @rosen-vladimirov above. However in the meantime if you need to use the |
Hey @vcooley , the issue is in CLI when regenerating the Podfile and I'm working on a fix. We'll do our best to release it in one of the next patches release of NativeScript CLI. |
Thanks for the fix. |
Hey @NathanWalker , |
The issue has surfaced again on iOS. disregard |
Hey guys, I would like to share some details about this case, why it reappeared in master branch and what's the current plan for the fix. Meanwhile we've received reports for similar issues for Android, where all plugins' We have not stopped looking into this case, but the solution of the incorrect regeneration is not a simple one. Also, we were still not sure why the Podfile is regenerated on your side. Please note that we have plans to merge #3768 and include it in 4.2.0 release. This should resolve your development workflow issues. The real fix for Podfile regeneration most probably will be included in the 4.2.1 release as it needs to be tested carefully. Hope this clears the case. We've not stopped working and investigating this issue. The main problem we had is to understand why CLI decides to prepare |
This comment was marked as abuse.
This comment was marked as abuse.
Hey @NathanaelA , the mentioned PR should fix exactly this behavior - no matter if you pass |
So @NathanaelA , @NathanWalker - the fix is in master branch and in CLI's next version. Can you give it a try and see if it resolves your issue? |
Hey @rosen-vladimirov, I can confirm Thanks again. :D |
Nice work @rosen-vladimirov 🙌 ❤️ |
Which platform(s) does your issue occur on?
iOS
Please provide the following version numbers that your issue occurs with:
Please tell us how to recreate the issue in as much detail as possible.
Running
tns run ios --clean
with this configuration produces a working build, however any changes made to the code cause the Podfile to be rebuilt in a way that causes a recursion error.Here is my Podfile (from
platforms/ios
) after the initial build:And here is my Podfile after making a change within my application's code. The problem occurs in the
post_install1
method, which recursively calls itself, but the entire Podfile is mangled:The text was updated successfully, but these errors were encountered: