Skip to content

Deploy and Run commands has the same behavior and different code implementations #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtopuzov opened this issue Mar 10, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@dtopuzov
Copy link
Contributor

It looks Deploy and Run both do the same:

  1. Prepare
  2. Build
  3. Deploy
  4. Run

Both commands have different implementations.
We should make them aliases and go with one single code implementation
Personally, I think deploy implementation is better (at least it handles invalid input better)

@dtopuzov dtopuzov added the bug label Mar 10, 2015
@Fatme Fatme self-assigned this Mar 12, 2015
@dtopuzov
Copy link
Contributor Author

Found a difference in iOS:
Run can run the app in simulator, Deploy can't deploy in simulator.

@dtopuzov dtopuzov added this to the 0.10 milestone Mar 13, 2015
@teobugslayer teobugslayer modified the milestones: 1.0, 0.10 Apr 24, 2015
@ikoevska ikoevska modified the milestones: 1.0.1, 1.0 Apr 27, 2015
@teobugslayer teobugslayer modified the milestones: 1.3.0, 1.2.0 Jul 14, 2015
@teobugslayer teobugslayer modified the milestones: 1.4.0, 1.3.0 Aug 31, 2015
@emiloberg
Copy link

To make things easier, wouldn't it be a good idea to remove one of the choices; run or deploy.

My vote is on removing the run as that would give us deploy for running on actual devices and 'emulate' for virtual devices. Clear separation.

@rosen-vladimirov
Copy link
Contributor

Hi @emiloberg ,
I'm wondering if we should duplicate the behavior or remove one of the commands. What do you think about making the deploy command just deploying to connected devices, without starting the application, while run will make deploy + starting of application. Emulate will make deploy on emulator + starting on emulator?

@emiloberg
Copy link

You're proposal works - if you can see a use case for just deploying an app without starting it. Personally I can't see why I want to do that, but there might be one.

Doing it this way still separates the commands for emulating and deploying (and running) which is I see as the most important part.

@rosen-vladimirov
Copy link
Contributor

As you've said - trying to find a use case for just deploying is really difficult. The only case I could think about is when you want to deploy several applications on different devices and check them after that.
In fact we have widely discussed command's behavior in this issue, so I'll close this one and we can continue our communication there. Thank you for the valuable feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants