Skip to content

3.0: ditch iOS build code and implement fastlane #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost opened this issue Mar 31, 2017 · 10 comments
Open

3.0: ditch iOS build code and implement fastlane #2679

ghost opened this issue Mar 31, 2017 · 10 comments
Labels
build Describes issues related to build operations epic feature os: ios publish Describes issues that are related to publishing applications

Comments

@ghost
Copy link

ghost commented Mar 31, 2017

iOS archiving, code signing, and exporting are fairly complex; the current implementation can only go so far esp. in some use cases, and the NS team has to constantly stay on top of it, like #2668.

Perusing ios-project-service, there are twists and turns to enable automatic or manual signing, juggle build configuration variables, hardcode xcodebuild parameters like exportOptionsPlist, etc.

I suggest ditching all of that stuff and plugging in fastlane. It does almost everything, does it flexibly, and is constantly updated and maintained; using it takes a big load off the shoulders of devs here.

Ping @NathanaelA @Plamen5kov

@ghost ghost changed the title 3.0: ditch xcodebuild/xcrun and implement fastlane 3.0: ditch iOS build code and implement fastlane Mar 31, 2017
@hypery2k
Copy link

I already plan to build an helper npm module, which extracts all the build helpers from the customer project. We already have an build numbering , release notes from git and upload via fast lane

@dtopuzov dtopuzov added the epic label May 9, 2017
@danielgek
Copy link

@hypery2k i was trying to setup fastlane for one of my projects, can you share your configs and if you have any advice, i would appreciate too

@hypery2k
Copy link

it's not finished yet, but there's an sample project with most of the code in it: https://github.com/holisticon/nativescript-ngx-demo

@PanayotCankov
Copy link
Contributor

@vbresults tns prepare ios --release was supposed to make an Xcode project in platforms/ios that can further be run and debugged in Xcode, built using xcodebuild, published with fastlane.

Could you elaborate on "ditch iOS build code and implement fastlane".

@ghost
Copy link
Author

ghost commented Aug 1, 2017

@PanayotCankov What I mean is that everything after the prepare step should be handled with fastlane which can cover any use case, not coded/maintained by the NS team who are already busy.

Whenever I've tried to build with fastlane after preparing, two things happen:

  1. Webpack is not triggered when I pass --bundle (also including --uglify)
  2. The build fails anyway: build-release.xcconfig line 3: Unable to find included file "../plugins-release.xcconfig.

@PanayotCankov
Copy link
Contributor

PanayotCankov commented Aug 3, 2017

@vbresults Webpack WIP: #2968
Once we split the preparation of the native plugins and resources from the preparation of .js files for the CLI built-in "bundling", we will be able to better suppress it and somehow either integrate the web pack into the CLI or decompose the CLI build steps on smaller tasks that can lead to better integration with the NativeScript webpack npm scripts.

On the other hand have you tried something like npm run build-ios-bundle ..., (this will do native build but still prepare the Xcode project in platforms/ios) and then run fastlane?

@ghost
Copy link
Author

ghost commented Aug 3, 2017

@PanayotCankov I see. I can't build with build-ios-bundle due to the issues mentioned in #3020. My environment has a limited amount of time for each build, so I can't build more than once at a time either.

@PanayotCankov
Copy link
Contributor

@sis0k0, is it possible to do something like npm run prepare-ios-bundle --uglify?

@spstratis
Copy link

spstratis commented Mar 29, 2018

Reading through this thread, is it possible to use FastLane for builds? I don't necessarily need it built into the TNS CLI right now but would love to use it for my own projects.

@hypery2k
Copy link

sure, see an example here.

@rosen-vladimirov rosen-vladimirov added build Describes issues related to build operations os: ios publish Describes issues that are related to publishing applications labels May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Describes issues related to build operations epic feature os: ios publish Describes issues that are related to publishing applications
Projects
None yet
Development

No branches or pull requests

7 participants