2.5.1 iOS incremental build generates inconsistent binary #2557
Comments
|
@toddanglin I can not reproduce with: Make whatever changes (in css, js, xml, break the app on purpose with invalid changes and then fix it) Same with release branch of https://github.com/NativeScript/sample-Groceries -> No issues. |
|
Let me try to create a project that reproduces the issue. Clearly, as per the forum thread, I'm not the only one encountering this error...but it's also clear that it's not impacting every project. I have a hunch that it could be related to plugins, most like i18n since it does the most during the build process. Let me test and report back... |
|
Still struggling to get a new project to recreate the error. Here is the series of log messages that occurs when a LiveSync happens on my existing app (run with Everything looks fine...the sync happens the app is refreshed...but then the process keeps going and seemingly attempts to build and refresh a 2nd time. Not sure if this will help trigger any ideas about what could be happening. Will keep trying to create a local, isolated problem reproduction. |
|
Okay. Got it. This simple hello-world project reproduces the error: The steps to recreate the project:
Let me know if you are unable to reproduce the problem using this project. Seems to be definitely related to the i18n plugin. To trigger, you must have the plugin installed and a strings.xml file in the project. |
|
All of this is likely also related to this Issue in the And this issue from 2.5.0: Not sure if this is a regression or if the problem that those threads suggest was fixed did not cover all the scenarios. But definitely looks like same problem, only more severe in 2.5.1. |
|
Thank you @toddanglin, |
|
FWIW, I've downgraded to 2.5.0 for now. Seems to be the only way to continue working with the i18n plugin until this build issue is resolved. |
|
Hey @toddanglin ,
What do you think? Ping @hshristov , @Plamen5kov as well. |
|
Personally, I like both Option 2 and 3.
Thinking of the CLI behavior before 2.5.0...the reason none of these problems existed was because LiveSync wouldn't attempt to do a native rebuild. The nativescript-i18n plugin would warn you that you'd need to manually trigger a full rebuild if you changed the strings definitions. And life was good. :) I'm wondering if another option to consider is a flag (or config option) for Adding @rborn since his plugin is one of the more popular impacted here. |
|
I'm for option 2. Power to the people!
@toddanglin I'm not so optimistic about the flag and here's why:
|
|
Any plans to patch this before 3.x? I'm stuck now between downgrading to 2.5.0 and getting endlessly looping builds or 2.5.2, which still breaks with i18n. May have to downgrade 2.4.x if a patch will take a while... |
|
@toddanglin we'll try to take a look at the concrete plugin and provide some workaround, and for 3.0 we should be able to introduce Option 2 as discussed, which will require some work on the plugin author`s side, but it's the best possible solution. |
|
@toddanglin can you tell me how exactly does the above demo fail with cli 2.5.2? |
|
Hi, I am experiencing the same issue with NS CLI 2.5.2 and NS SASS plugin. Steps to reproduce:
Here is log that is printed when running A single file change results in multiple builds and syncs to the iOS simulator. Just as @toddanglin I will have to downgrade to 2.5.0 until this is fixed. |
|
@abinici thank you for the detailed steps. I managed to reproduce the problem, and I'll start investigating right away. |
|
@Plamen5kov I think the problem is that both plugins (sass and mine) write something in the watched folder. So livesync will think something got updated and rebuild which will trigger another re-write, and so on.. 😃 |
|
yeah 😞 |
|
By popular vote, we'll implement option 2. We'll provide more information to the plugin authors through the |
|
Hey guys, can you checkout our @next and tell us if what you requested is covered as you expected? |
|
Hi @pkoleva , here is what I did to repeat my previous test:
Now, when I run Before installing sass there is no problem building and running the app. Maybe sass-plugin is not compatible with version 3 of Nativescript? Here is the output of |
|
This is expected since the plugin authors haven't updated the plugins, in compliance with the changes with CLI from @next, where they have more info coming in during livesync. |
|
@pkoleva I'm a little overloaded these weeks, but as soon as I have a little time I'll give it a shot 😄 |
|
I'm having the same issues, except using nativescript-dev-less instead of sass. It's very difficult to do anything sort of development. Is there currently any resolution here other than downgrading my TNS version to 2.4 or removing the dependency? |
|
All the changes, required by the plugin developers are already in master, so as soon as the plugin developers, update their respective plugins to use the newly provided information, the problems will be solved. |
|
@Plamen5kov could you give us some links where we should look ? (commits, docs, etc?) |
|
@rborn sure: These changes are available in @next. |
|
Are there any sample hooks using the hookArgs data? It accepted it as an allowable hook parameter however the variable was always undefined. edit: I found it in use in nativescript-dev-babel, I'm going to start a clean project to isolate why I was getting undefined. |
There appears to be an issue with 2.5.1 that is corrupting all incremental iOS builds targeting the simulator. The issue is captured and well described here:
https://discourse.nativescript.org/t/ns-2-5-1-ios-incremental-build-generates-inconsistent-binary/591
Steps to reproduce:
tns buildortns deploy)This problem did not exist in 2.5.0.
The text was updated successfully, but these errors were encountered: