Skip to content

hooks inside app folder for template-hello-world-ng on tns create #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leocaseiro opened this issue Nov 21, 2016 · 2 comments
Closed

hooks inside app folder for template-hello-world-ng on tns create #2240

leocaseiro opened this issue Nov 21, 2016 · 2 comments
Assignees
Milestone

Comments

@leocaseiro
Copy link

I was going to open this issue on template-hello-world-ng. However, there're no issues on that repo.

After creating a new project using the template-hello-world-ng, I've noticed that inside the project comes with a file ./app/hooks/before-livesync/nativescript-angular.sync.js, however, the same file is on the correct folder ./hooks/before-livesync/nativescript-angular.sync.js.

I was wondering if that suppose to be there or it's a new setup that I'm not aware.

To reproduce it, just run:

tns create myapp --template tns-template-hello-world-ng

PS: I've tried to check if other templates come with the hook into app folder, but none of them did, so I thought it would be worth open this issue.

@leocaseiro leocaseiro changed the title hooks inside app folder for template-hello-world-ng hooks inside app folder for template-hello-world-ng on tns create Nov 21, 2016
@NickIliev NickIliev added the bug label Nov 21, 2016
@NickIliev
Copy link
Contributor

NickIliev commented Nov 21, 2016

Hey @leocaseiro

Thank you for reporting this issue - I have tested it on my side and can confirm that the described inconsistency is observed with

tns create myapp --template tns-template-hello-world-ng

// this will create additional hooks folder in app/

but is not observed with

tns create myapp --ng

// ok

use the shorthand as a workaround - we will investigate and apply a fix for the --template syntax.

@tsonevn tsonevn added this to the 2.5.0 milestone Dec 5, 2016
@Plamen5kov Plamen5kov self-assigned this Dec 8, 2016
@Plamen5kov
Copy link
Contributor

Plamen5kov commented Dec 8, 2016

fixed in master (2.5.0)

@Plamen5kov Plamen5kov reopened this Dec 8, 2016
@pkoleva pkoleva closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants