Skip to content

Remove SUPPORTED_TARGETS from CLI #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blagoev opened this issue Nov 7, 2016 · 1 comment
Open

Remove SUPPORTED_TARGETS from CLI #2203

blagoev opened this issue Nov 7, 2016 · 1 comment

Comments

@blagoev
Copy link
Contributor

blagoev commented Nov 7, 2016

Currently we have a white list for supported android sdk version in CLI. This was done in the early days to protect developers from using not supported android sdks. This was especially valid when android releases were final from day 1. Nowadays android sdk enter preview/beta stages early so we can remove this hard coded list of supported sdks

Goals:

  • users are able to benefit of {N} 0-day support
  • users to be in control of what compile sdk version is used for their apps
@blagoev
Copy link
Contributor Author

blagoev commented Nov 7, 2016

After short discussion with @rosen-vladimirov we decided that the best approach here is to detect the latest Android SDK that is installed and is not preview and use that as compileSDK to compile the project. If the user wants he can specify --compileSDK as a flag on the build command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants