Do not stop process when EPEERINVALID error is raised #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many cases `npm install` command, that CLI calls, will raise EPEERINVALID error (on Linux and Mac OS X). This error code indicates that some of the dependencies have peer dependencies that are not included in the project. Npm 2 considers this case as error and raises EPEERINVALID error. However in npm 3 this case is treated as non-errornous case and instead of EPEERINVALID, only WARNINGIS are shown. CLI uses npm 2 internally (as dependency), so whenever such case happens, it breaks its execution. Until the dependency is updated, let's treat these errors as warnings and continue the execution. After we upgrade the dependency to npm 3 we'll have the same behavior.
rosen-vladimirov
force-pushed
the
vladimirov/peer-deps
branch
from
9622bad to
1e186ea
Compare
enchev
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases
npm installcommand, that CLI calls, will raise EPEERINVALID error (on Linux and Mac OS X).This error code indicates that some of the dependencies have peer dependencies that are not included in the project.
Npm 2 considers this case as error and raises EPEERINVALID error. However in npm 3 this case is treated as non-errornous case and instead of EPEERINVALID, only WARNINGIS are shown.
CLI uses npm 2 internally (as dependency), so whenever such case happens, it breaks its execution.
Until the dependency is updated, let's treat these errors as warnings and continue the execution. After we upgrade the dependency to npm 3 we'll have the same behavior.