Skip to content

Commit fd15624

Browse files
committed
fix ios-debug after merge
1 parent 5763a53 commit fd15624

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

lib/services/ios-debug-service.ts

+1-8
Original file line numberDiff line numberDiff line change
@@ -203,17 +203,10 @@ class IOSDebugService implements IDebugService {
203203
private openDebuggerClient(fileDescriptor: string): IFuture<void> {
204204
if (this.$options.client) {
205205
return (() => {
206-
let inspectorPath = this.$npmInstallationManager.install(inspectorNpmPackageName).wait();
206+
let inspectorPath = this.$npmInstallationManager.install(inspectorNpmPackageName, this.$projectData.projectDir).wait();
207207
let inspectorSourceLocation = path.join(inspectorPath, inspectorUiDir, "Main.html");
208208
let inspectorApplicationPath = path.join(inspectorPath, inspectorAppName);
209209

210-
// TODO : Sadly $npmInstallationManager.install does not install the package, it only inserts it in the cache through the npm cache add command
211-
// Since npm cache add command does not execute scripts our posinstall script that extract the Inspector Application does not execute as well
212-
// So until this behavior is changed this ugly workaround should not be deleted
213-
if (!this.$fs.exists(inspectorApplicationPath).wait()) {
214-
this.$npm.executeNpmCommand("npm run-script postinstall", inspectorPath).wait();
215-
}
216-
217210
let cmd = `open -a '${inspectorApplicationPath}' --args '${inspectorSourceLocation}' '${this.$projectData.projectName}' '${fileDescriptor}'`;
218211
this.$childProcess.exec(cmd).wait();
219212
}).future<void>()();

0 commit comments

Comments
 (0)