Merge pull request #3537 from NativeScript/vladimirov/fix-analytics-logs

rosen-vladimirov · web-flow · commit f88549c14459 · 2018-04-19T10:11:32.000+03:00
fix(analytics): Message for tracking in GA is always printed
diff --git a/lib/services/analytics/analytics-service.ts b/lib/services/analytics/analytics-service.ts
@@ -58,6 +58,7 @@ export class AnalyticsService extends AnalyticsServiceBase {
 			gaSettings.customDimensions[GoogleAnalyticsCustomDimensions.client] = this.$options.analyticsClient || (isInteractive() ? AnalyticsClients.Cli : AnalyticsClients.Unknown);
 
 			const googleAnalyticsData: IGoogleAnalyticsTrackingInformation = _.merge({ type: TrackingTypes.GoogleAnalyticsData, category: AnalyticsClients.Cli }, gaSettings);
+			this.$logger.trace("Will send the following information to Google Analytics:", googleAnalyticsData);
 			return this.sendMessageToBroker(googleAnalyticsData);
 		}
 	}
@@ -99,8 +100,6 @@ export class AnalyticsService extends AnalyticsServiceBase {
 			customDimensions
 		};
 
-		this.$logger.trace("Will send the following information to Google Analytics:", googleAnalyticsEventData);
-
 		await this.trackInGoogleAnalytics(googleAnalyticsEventData);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ export class AnalyticsService extends AnalyticsServiceBase {`
`58`	`58`	`gaSettings.customDimensions[GoogleAnalyticsCustomDimensions.client] = this.$options.analyticsClient \|\| (isInteractive() ? AnalyticsClients.Cli : AnalyticsClients.Unknown);`
`59`	`59`
`60`	`60`	`const googleAnalyticsData: IGoogleAnalyticsTrackingInformation = _.merge({ type: TrackingTypes.GoogleAnalyticsData, category: AnalyticsClients.Cli }, gaSettings);`
	`61`	`+ this.$logger.trace("Will send the following information to Google Analytics:", googleAnalyticsData);`
`61`	`62`	`return this.sendMessageToBroker(googleAnalyticsData);`
`62`	`63`	`}`
`63`	`64`	`}`
`@@ -99,8 +100,6 @@ export class AnalyticsService extends AnalyticsServiceBase {`
`99`	`100`	`customDimensions`
`100`	`101`	`};`
`101`	`102`
`102`		`- this.$logger.trace("Will send the following information to Google Analytics:", googleAnalyticsEventData);`
`103`		`-`
`104`	`103`	`await this.trackInGoogleAnalytics(googleAnalyticsEventData);`
`105`	`104`	`}`
`106`	`105`