Skip to content

Commit f826248

Browse files
authored
fix(plugins): parse name issue with invalid plugins (#5770)
1 parent e3ef37d commit f826248

File tree

1 file changed

+24
-17
lines changed

1 file changed

+24
-17
lines changed

lib/services/plugins-service.ts

+24-17
Original file line numberDiff line numberDiff line change
@@ -623,25 +623,32 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
623623
cacheData: IDependencyData | INodeModuleData,
624624
projectDir: string
625625
): IPluginData {
626-
const pluginData: any = {};
627-
pluginData.name = cacheData.name;
628-
pluginData.version = cacheData.version;
629-
pluginData.fullPath =
630-
(<IDependencyData>cacheData).directory ||
631-
path.dirname(
632-
this.getPackageJsonFilePathForModule(cacheData.name, projectDir)
626+
try {
627+
const pluginData: any = {};
628+
pluginData.name = cacheData.name;
629+
pluginData.version = cacheData.version;
630+
pluginData.fullPath =
631+
(<IDependencyData>cacheData).directory ||
632+
path.dirname(
633+
this.getPackageJsonFilePathForModule(cacheData.name, projectDir)
634+
);
635+
pluginData.isPlugin = !!cacheData.nativescript;
636+
pluginData.pluginPlatformsFolderPath = (platform: string) =>
637+
path.join(pluginData.fullPath, "platforms", platform.toLowerCase());
638+
const data = cacheData.nativescript;
639+
640+
if (pluginData.isPlugin) {
641+
pluginData.platformsData = data.platforms;
642+
pluginData.pluginVariables = data.variables;
643+
}
644+
} catch (err) {
645+
this.$logger.trace(
646+
"NOTE: There appears to be a problem with this dependency:",
647+
cacheData.name
633648
);
634-
pluginData.isPlugin = !!cacheData.nativescript;
635-
pluginData.pluginPlatformsFolderPath = (platform: string) =>
636-
path.join(pluginData.fullPath, "platforms", platform.toLowerCase());
637-
const data = cacheData.nativescript;
638-
639-
if (pluginData.isPlugin) {
640-
pluginData.platformsData = data.platforms;
641-
pluginData.pluginVariables = data.variables;
649+
this.$logger.trace(err);
650+
return null;
642651
}
643-
644-
return pluginData;
645652
}
646653

647654
private removeDependencyFromPackageJsonContent(

0 commit comments

Comments
 (0)