Skip to content

Commit ee05e03

Browse files
committed
chore: fix comments
1 parent 97684f2 commit ee05e03

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

lib/bootstrap.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ $injector.require("bundleValidatorHelper", "./helpers/bundle-validator-helper");
128128
$injector.require("androidBundleValidatorHelper", "./helpers/android-bundle-validator-helper");
129129
$injector.require("liveSyncCommandHelper", "./helpers/livesync-command-helper");
130130
$injector.require("deployCommandHelper", "./helpers/deploy-command-helper");
131-
$injector.require("optionsTrackHelper", "./helpers/options-track-helper");
131+
$injector.require("optionsTracker", "./helpers/options-track-helper");
132132

133133
$injector.requirePublicClass("localBuildService", "./services/local-build-service");
134134
$injector.requirePublicClass("liveSyncService", "./services/livesync/livesync-service");

lib/common/services/commands-service.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export class CommandsService implements ICommandsService {
3131
private $staticConfig: Config.IStaticConfig,
3232
private $helpService: IHelpService,
3333
private $extensibilityService: IExtensibilityService,
34-
private $optionsTrackHelper: IOptionsTrackHelper) {
34+
private $optionsTracker: IOptionsTracker) {
3535
}
3636

3737
public allCommands(opts: { includeDevCommands: boolean }): string[] {
@@ -64,7 +64,7 @@ export class CommandsService implements ICommandsService {
6464
}
6565

6666
await analyticsService.trackInGoogleAnalytics(googleAnalyticsPageData);
67-
await this.$optionsTrackHelper.trackOptions(this.$options);
67+
await this.$optionsTracker.trackOptions(this.$options);
6868
}
6969

7070
const shouldExecuteHooks = !this.$staticConfig.disableCommandHooks && (command.enableHooks === undefined || command.enableHooks === true);

lib/declarations.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,7 @@ interface IAndroidBundleValidatorHelper {
910910
validateRuntimeVersion(projectData: IProjectData): void
911911
}
912912

913-
interface IOptionsTrackHelper {
913+
interface IOptionsTracker {
914914
trackOptions(options: IOptions): Promise<void>
915915
}
916916

lib/helpers/options-track-helper.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as path from "path";
22
import { TrackActionNames } from "../constants";
33

4-
export class OptionsTrackHelper {
4+
export class OptionsTracker {
55
public static PASSWORD_DETECTION_STRING = "password";
66
public static PASSOWRD_REPLACE_VALUE = "private";
77
public static PATH_REPLACE_VALUE = "_localpath";
@@ -34,10 +34,10 @@ export class OptionsTrackHelper {
3434
if (this.shouldSkipProperty(key, value, shorthands, optionsDefinitions)) {
3535
delete data[key];
3636
} else {
37-
if (key.toLowerCase().indexOf(OptionsTrackHelper.PASSWORD_DETECTION_STRING) >= 0) {
38-
value = OptionsTrackHelper.PASSOWRD_REPLACE_VALUE;
37+
if (key.toLowerCase().indexOf(OptionsTracker.PASSWORD_DETECTION_STRING) >= 0) {
38+
value = OptionsTracker.PASSOWRD_REPLACE_VALUE;
3939
} else if (_.isString(value) && value !== path.basename(value)) {
40-
value = OptionsTrackHelper.PATH_REPLACE_VALUE;
40+
value = OptionsTracker.PATH_REPLACE_VALUE;
4141
} else if (_.isObject(value) && !_.isArray(value)) {
4242
value = this.sanitizeTrackObject(value);
4343
}
@@ -74,4 +74,4 @@ export class OptionsTrackHelper {
7474
}
7575
}
7676

77-
$injector.register("optionsTrackHelper", OptionsTrackHelper);
77+
$injector.register("optionsTracker", OptionsTracker);

0 commit comments

Comments
 (0)