Skip to content

Commit ed0343a

Browse files
committed
chore: fix PR comments
1 parent 0f8e88e commit ed0343a

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

lib/definitions/gradle.d.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ interface IGradleCommandService {
33
}
44

55
interface IGradleCommandOptions {
6-
message?: string;
76
cwd: string;
7+
message?: string;
88
stdio?: string;
9-
spawnOptions?: any;
9+
spawnOptions?: ISpawnFromEventOptions;
1010
}
1111

1212
interface IAndroidBuildConfig extends IRelease, IAndroidReleaseOptions, IHasAndroidBundle {
@@ -21,4 +21,4 @@ interface IGradleBuildService {
2121
interface IGradleBuildArgsService {
2222
getBuildTaskArgs(buildConfig: IAndroidBuildConfig): string[];
2323
getCleanTaskArgs(buildConfig: IAndroidBuildConfig): string[];
24-
}
24+
}

lib/services/android-project-service.ts

-1
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,6 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
359359
}
360360

361361
public async cleanProject(projectRoot: string, projectData: IProjectData): Promise<void> {
362-
// TODO: Check why there isn't a clean release build and a clean release aab build
363362
await this.$gradleBuildService.cleanProject(projectRoot, { release: false });
364363
}
365364

lib/services/android/gradle-build-args-service.ts

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export class GradleBuildArgsService implements IGradleBuildArgsService {
2525
const toolsInfo = this.$androidToolsInfo.getToolsInfo();
2626
args.push(
2727
`-PcompileSdk=android-${toolsInfo.compileSdkVersion}`,
28+
`-PtargetSdk=${toolsInfo.targetSdkVersion}`,
2829
`-PbuildToolsVersion=${toolsInfo.buildToolsVersion}`,
2930
`-PgenerateTypings=${toolsInfo.generateTypings}`
3031
);

lib/services/android/gradle-command-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class GradleCommandService implements IGradleCommandService {
1818
return result;
1919
}
2020

21-
private async executeCommandSafe(gradleExecutable: string, gradleArgs: string[], childProcessOptions: any, spawnOptions: any) {
21+
private async executeCommandSafe(gradleExecutable: string, gradleArgs: string[], childProcessOptions: { cwd: string, stdio: string }, spawnOptions: ISpawnFromEventOptions) {
2222
try {
2323
const result = await this.$childProcess.spawnFromEvent(gradleExecutable, gradleArgs, "close", childProcessOptions, spawnOptions);
2424

0 commit comments

Comments
 (0)