Skip to content

Commit e91e674

Browse files
committed
revert: fix: exclude arm64 architecture
1 parent 85ba876 commit e91e674

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

lib/services/ios/xcodebuild-args-service.ts

-6
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,6 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
122122
args.push("ONLY_ACTIVE_ARCH=NO");
123123
}
124124

125-
if (!devicesArchitectures.includes("arm64")) {
126-
// don't build form arm64 if we have no arm64 targets
127-
// todo: re-visit if arm64 simulators start failing
128-
args.push("EXCLUDED_ARCHS=arm64");
129-
}
130-
131125
return args;
132126
}
133127

test/services/ios/xcodebuild-args-service.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ describe("xcodebuildArgsService", () => {
9595

9696
const expectedArgs = [
9797
"ONLY_ACTIVE_ARCH=NO",
98-
"EXCLUDED_ARCHS=arm64",
9998
"CODE_SIGN_IDENTITY=",
10099
"build",
101100
"-configuration",
@@ -137,9 +136,7 @@ describe("xcodebuildArgsService", () => {
137136
{
138137
name: "should return correct args when no connected devices",
139138
connectedDevices: [],
140-
expectedArgs: ["EXCLUDED_ARCHS=arm64", "-sdk", "iphoneos"].concat(
141-
getCommonArgs()
142-
),
139+
expectedArgs: ["-sdk", "iphoneos"].concat(getCommonArgs()),
143140
},
144141
];
145142

0 commit comments

Comments
 (0)