Skip to content

Commit df42abe

Browse files
Fix check for android local builds
Fix the check for Android Local Builds to check all required compontents from androidToolsInfo.
1 parent f7ed558 commit df42abe

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

lib/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const androidToolsInfo = new AndroidToolsInfo(childProcess, fileSystem, hostInfo
1919

2020
const sysInfo: NativeScriptDoctor.ISysInfo = new SysInfo(childProcess, fileSystem, helpers, hostInfo, winReg, androidToolsInfo);
2121

22-
const androidLocalBuildRequirements = new AndroidLocalBuildRequirements(sysInfo);
22+
const androidLocalBuildRequirements = new AndroidLocalBuildRequirements(androidToolsInfo, sysInfo);
2323
const iOSLocalBuildRequirements = new IosLocalBuildRequirements(sysInfo, hostInfo);
2424

2525
const doctor: NativeScriptDoctor.IDoctor = new Doctor(androidLocalBuildRequirements, helpers, hostInfo, iOSLocalBuildRequirements, sysInfo, androidToolsInfo);

lib/local-build-requirements/android-local-build-requirements.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
export class AndroidLocalBuildRequirements {
2-
constructor(private sysInfo: NativeScriptDoctor.ISysInfo) { }
2+
constructor(private androidToolsInfo: NativeScriptDoctor.IAndroidToolsInfo,
3+
private sysInfo: NativeScriptDoctor.ISysInfo) { }
34

45
public async checkRequirements(): Promise<boolean> {
5-
if (!await this.sysInfo.getJavaCompilerVersion() ||
6+
const androidToolsInfo = await this.androidToolsInfo.validateInfo();
7+
if (androidToolsInfo.length ||
8+
!await this.sysInfo.getJavaCompilerVersion() ||
69
!await this.sysInfo.getJavaVersion() ||
710
!await this.sysInfo.getAdbVersion()) {
811
return false;

0 commit comments

Comments
 (0)