Skip to content

Commit da0c5da

Browse files
feat: set min required compile SDK to 28
As we are going to set min required Android Support Library to be 28 (in the modules), we need to set the min required compile SDK to 28 as well (as Android Support Library 28 relies on resources included in this version of the SDK and the project cannot be build without them). This way CLI will not allow building an application without installing the Android SDK 28 first.
1 parent 8c3d920 commit da0c5da

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/android-tools-info.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
2222
"android-27",
2323
"android-28",
2424
];
25-
private static MIN_REQUIRED_COMPILE_TARGET = 22;
25+
private static MIN_REQUIRED_COMPILE_TARGET = 28;
2626
private static REQUIRED_BUILD_TOOLS_RANGE_PREFIX = ">=23";
2727
private static VERSION_REGEX = /((\d+\.){2}\d+)/;
2828
private static MIN_JAVA_VERSION = "1.8.0";

0 commit comments

Comments
 (0)