Merge pull request #4210 from NativeScript/fatme/fix-max-listeners-exceeded

fix: fix "MaxEventListeners detected" error when livesync is started more than 11 times from sidekick

Author: Fatme

lib/services/livesync/livesync-service.ts

@@ -56,9 +56,7 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
 	}
 
 	public async liveSyncToPreviewApp(data: IPreviewAppLiveSyncData): Promise<IQrCodeImageData> {
-		this.$previewAppLiveSyncService.on(LiveSyncEvents.previewAppLiveSyncError, liveSyncData => {
-			this.emit(LiveSyncEvents.previewAppLiveSyncError, liveSyncData);
-		});
+		this.attachToPreviewAppLiveSyncError();
 
 		await this.liveSync([], {
 			syncToPreviewApp: true,
@@ -139,6 +137,13 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi
 		return currentDescriptors || [];
 	}
 
+	@cache()
+	private attachToPreviewAppLiveSyncError(): void {
+		this.$previewAppLiveSyncService.on(LiveSyncEvents.previewAppLiveSyncError, liveSyncData => {
+			this.emit(LiveSyncEvents.previewAppLiveSyncError, liveSyncData);
+		});
+	}
+
 	private handleWarnings(liveSyncData: ILiveSyncInfo, projectData: IProjectData) {
 		if (liveSyncData.useHotModuleReload) {
 			this.$logger.warn("Hot Module Replacement (HMR) is currently in Beta. For more information about the current development state and any known issues, please check the relevant GitHub issue: https://github.com/NativeScript/NativeScript/issues/6398");

npm-shrinkwrap.json

@@ -59,7 +59,7 @@
     "mkdirp": "0.5.1",
     "mute-stream": "0.0.5",
     "nativescript-doctor": "1.8.1",
-    "nativescript-preview-sdk": "0.3.1",
+    "nativescript-preview-sdk": "0.3.2",
     "open": "0.0.5",
     "ora": "2.0.0",
     "osenv": "0.1.3",