Skip to content

Commit d849447

Browse files
committed
fix: do not require signing when the aab will not be deployed by the CLI
1 parent e75acf8 commit d849447

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

lib/commands/build.ts

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ANDROID_RELEASE_BUILD_ERROR_MESSAGE, AndroidAppBundleMessages, ANDROID_APP_BUNDLE_SIGNING_ERROR_MESSAGE } from "../constants";
1+
import { ANDROID_RELEASE_BUILD_ERROR_MESSAGE, AndroidAppBundleMessages } from "../constants";
22
import { ValidatePlatformCommandBase } from "./command-base";
33
import { hasValidAndroidSigning } from "../common/helpers";
44

@@ -124,12 +124,8 @@ export class BuildAndroidCommand extends BuildCommandBase implements ICommand {
124124
this.$androidBundleValidatorHelper.validateRuntimeVersion(this.$projectData);
125125
let canExecute = await super.canExecuteCommandBase(platform, { notConfiguredEnvOptions: { hideSyncToPreviewAppOption: true } });
126126
if (canExecute) {
127-
if ((this.$options.release || this.$options.aab) && !hasValidAndroidSigning(this.$options)) {
128-
if (this.$options.release) {
129-
this.$errors.failWithHelp(ANDROID_RELEASE_BUILD_ERROR_MESSAGE);
130-
} else {
131-
this.$errors.failWithHelp(ANDROID_APP_BUNDLE_SIGNING_ERROR_MESSAGE);
132-
}
127+
if (this.$options.release && !hasValidAndroidSigning(this.$options)) {
128+
this.$errors.failWithHelp(ANDROID_RELEASE_BUILD_ERROR_MESSAGE);
133129
}
134130

135131
canExecute = await super.validateArgs(args, platform);

0 commit comments

Comments
 (0)