Skip to content

Commit d82e34c

Browse files
committed
fix: add forgotten migrate dependencies for Vue and Angular apps
1 parent 5e1d236 commit d82e34c

File tree

1 file changed

+30
-11
lines changed

1 file changed

+30
-11
lines changed

lib/controllers/migrate-controller.ts

+30-11
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,15 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
6969
{ packageName: "nativescript-datetimepicker", verifiedVersion: "1.1.0" },
7070
{ packageName: "kinvey-nativescript-sdk", verifiedVersion: "4.2.1" },
7171
{ packageName: "nativescript-plugin-firebase", verifiedVersion: "9.0.2" },
72-
{ packageName: "nativescript-vue", verifiedVersion: "2.3.0" },
72+
{
73+
packageName: "nativescript-vue", verifiedVersion: "2.3.0",
74+
shouldMigrateAction: async (projectData: IProjectData, allowInvalidVersions: boolean) => {
75+
const dependency = { packageName: "nativescript-vue", verifiedVersion: "2.3.0", isDev: false };
76+
const result = this.hasDependency(dependency, projectData) && await this.shouldMigrateDependencyVersion(dependency, projectData, allowInvalidVersions);
77+
return result;
78+
},
79+
migrateAction: this.migrateNativeScriptVue.bind(this)
80+
},
7381
{
7482
packageName: "nativescript-angular", verifiedVersion: "8.0.2",
7583
shouldMigrateAction: async (projectData: IProjectData, allowInvalidVersions: boolean) => {
@@ -387,16 +395,27 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
387395

388396
private async migrateNativeScriptAngular(): Promise<IMigrationDependency[]> {
389397
const dependencies = [
390-
{ packageName: "@angular/platform-browser-dynamic", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
391-
{ packageName: "@angular/common", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
392-
{ packageName: "@angular/compiler", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
393-
{ packageName: "@angular/core", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
394-
{ packageName: "@angular/forms", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
395-
{ packageName: "@angular/http", verifiedVersion: "8.0.0-beta.10", shouldAddIfMissing: true },
396-
{ packageName: "@angular/platform-browser", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
397-
{ packageName: "@angular/router", verifiedVersion: "8.0.0", shouldAddIfMissing: true },
398-
{ packageName: "rxjs", verifiedVersion: "6.3.3", shouldAddIfMissing: true },
399-
{ packageName: "zone.js", verifiedVersion: "0.9.1", shouldAddIfMissing: true }
398+
{ packageName: "@angular/platform-browser-dynamic", verifiedVersion: "8.0.0" },
399+
{ packageName: "@angular/common", verifiedVersion: "8.0.0" },
400+
{ packageName: "@angular/compiler", verifiedVersion: "8.0.0" },
401+
{ packageName: "@angular/core", verifiedVersion: "8.0.0" },
402+
{ packageName: "@angular/forms", verifiedVersion: "8.0.0" },
403+
{ packageName: "@angular/http", verifiedVersion: "8.0.0-beta.10" },
404+
{ packageName: "@angular/platform-browser", verifiedVersion: "8.0.0" },
405+
{ packageName: "@angular/router", verifiedVersion: "8.0.0" },
406+
{ packageName: "rxjs", verifiedVersion: "6.3.3" },
407+
{ packageName: "zone.js", verifiedVersion: "0.9.1" },
408+
{ packageName: "@angular/animations", verifiedVersion: "8.0.0" },
409+
{ packageName: "@angular/compiler-cli", verifiedVersion: "8.0.0", isDev: true },
410+
{ packageName: "@ngtools/webpack", verifiedVersion: "8.0.0", isDev: true }
411+
];
412+
413+
return dependencies;
414+
}
415+
416+
private async migrateNativeScriptVue(): Promise<IMigrationDependency[]> {
417+
const dependencies = [
418+
{ packageName: "nativescript-vue-template-compiler", verifiedVersion: "2.3.0", isDev: true }
400419
];
401420

402421
return dependencies;

0 commit comments

Comments
 (0)