Skip to content

Commit d625f28

Browse files
committed
Merge pull request #1423 from NativeScript/kerezov/disable-hooks
Separate disableCommandHooks from DISABLE_HOOKS
2 parents 4df5e79 + 90d3eaf commit d625f28

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

config/config.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@
66
"TYPESCRIPT_COMPILER_OPTIONS": {},
77
"CI_LOGGER": false,
88
"ANDROID_DEBUG_UI_MAC": "Google Chrome",
9-
"USE_POD_SANDBOX": true
10-
}
9+
"USE_POD_SANDBOX": true,
10+
"DISABLE_HOOKS": false
11+
}

lib/config.ts

+6-5
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
"use strict";
33

44
import * as path from "path";
5-
import * as staticConfigBaseLibPath from "./common/static-config-base";
6-
import * as configBaseLib from "./common/config-base";
5+
import {StaticConfigBase} from "./common/static-config-base";
6+
import {ConfigBase} from "./common/config-base";
77

8-
export class Configuration extends configBaseLib.ConfigBase implements IConfiguration { // User specific config
8+
export class Configuration extends ConfigBase implements IConfiguration { // User specific config
99
CI_LOGGER = false;
1010
DEBUG = false;
1111
TYPESCRIPT_COMPILER_OPTIONS = {};
@@ -21,7 +21,7 @@ export class Configuration extends configBaseLib.ConfigBase implements IConfigur
2121
}
2222
$injector.register("config", Configuration);
2323

24-
export class StaticConfig extends staticConfigBaseLibPath.StaticConfigBase implements IStaticConfig {
24+
export class StaticConfig extends StaticConfigBase implements IStaticConfig {
2525
public PROJECT_FILE_NAME = "package.json";
2626
public CLIENT_NAME_KEY_IN_PROJECT_FILE = "nativescript";
2727
public CLIENT_NAME = "tns";
@@ -37,7 +37,8 @@ export class StaticConfig extends staticConfigBaseLibPath.StaticConfigBase imple
3737
this.RESOURCE_DIR_PATH = path.join(this.RESOURCE_DIR_PATH, "../../resources");
3838
}
3939

40-
public get disableHooks() {
40+
public get disableCommandHooks() {
41+
// Never set this to false because it will duplicate execution of hooks realized through method decoration
4142
return true;
4243
}
4344

0 commit comments

Comments
 (0)