Skip to content

Commit d5725e0

Browse files
committed
fix PR comments
1 parent 395e476 commit d5725e0

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

lib/commands/clean-app.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class CleanAppCommandBase extends ValidatePlatformCommandBase implements
1717
}
1818

1919
public async execute(args: string[]): Promise<void> {
20-
this.$logger.warn(`"tns clean-app ${this.platform.toLowerCase()}" command has been deprecated and will be removed in the upcoming NativeScript CLI v.6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
20+
this.$logger.warn(`"tns clean-app ${this.platform.toLowerCase()}" command has been deprecated and will be removed in the upcoming NativeScript CLI v6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
2121

2222
const appFilesUpdaterOptions: IAppFilesUpdaterOptions = {
2323
bundle: !!this.$options.bundle,

lib/options.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -206,15 +206,16 @@ export class Options {
206206

207207
public printMessagesForDeprecatedOptions($logger: ILogger) {
208208
if (this.argv.platformTemplate) {
209-
$logger.warn(`"--platformTemplate" option has been deprecated and will be removed in the upcoming NativeScript CLI v.6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
209+
$logger.warn(`"--platformTemplate" option has been deprecated and will be removed in the upcoming NativeScript CLI v6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
210210
}
211211

212212
if (this.argv.syncAllFiles) {
213-
$logger.warn(`"--syncAllFiles" option has been deprecated and will be removed in the upcoming NativeScript CLI v.6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
213+
$logger.warn(`"--syncAllFiles" option has been deprecated and will be removed in the upcoming NativeScript CLI v6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
214214
}
215215

216216
if (this.argv.bundle) {
217-
$logger.warn(`"--bundle" option has been deprecated and as of NativeScript CLI v.6.0.0 Webpack workflow will become the only way of building apps.`);
217+
$logger.warn(`"--bundle" option has been deprecated and as of NativeScript CLI v6.0.0 Webpack workflow will become the only way of building apps.
218+
More info about the reasons for this change and how to migrate your project can be found in the link below: <TODO: add link here>`);
218219
}
219220
}
220221

lib/services/platform-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ export class PlatformService extends EventEmitter implements IPlatformService {
321321
const platformData = this.$platformsData.getPlatformData(platform, projectData);
322322
const frameworkVersion = this.getCurrentPlatformVersion(platform, projectData);
323323
if (semver.lt(semver.coerce(frameworkVersion), semver.coerce('5.1.0'))) {
324-
this.$logger.warn(`Runtime versions lower than 5.1.0 have been deprecated and will not be supported as of v.6.0.0 of NativeScript CLI. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
324+
this.$logger.warn(`Runtime versions lower than 5.1.0 have been deprecated and will not be supported as of v6.0.0 of NativeScript CLI. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
325325
}
326326

327327
const projectFilesConfig = helpers.getProjectFilesConfig({ isReleaseBuild: appFilesUpdaterOptions.release });

0 commit comments

Comments
 (0)