Skip to content

Commit d241c49

Browse files
FatmeFatme
Fatme
authored and
Fatme
committed
Merge pull request #1034 from NativeScript/fatme/fix-invalid-version
Fix "Invalid Version: undefined" when adding a plugin
2 parents b7df627 + 69fbe48 commit d241c49

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

lib/services/plugins-service.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -385,9 +385,7 @@ export class PluginsService implements IPluginsService {
385385
if(!pluginVersion) {
386386
this.$logger.warn(`${pluginData.name} is not supported for ${platform}.`);
387387
isValid = false;
388-
}
389-
390-
if(semver.gt(pluginVersion, installedFrameworkVersion)) {
388+
} else if(semver.gt(pluginVersion, installedFrameworkVersion)) {
391389
this.$logger.warn(`${pluginData.name} ${pluginVersion} for ${platform} is not compatible with the currently installed framework version ${installedFrameworkVersion}.`);
392390
isValid = false;
393391
}

0 commit comments

Comments
 (0)