Skip to content

Commit cde4fd6

Browse files
committed
Review
1 parent 09fb30c commit cde4fd6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CocoaPods.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Next, install the plugin:
8585
tns plugin add ../my-plugin
8686
```
8787

88-
> **NOTE:** By default, all CocoaPods are installed as [shared frameworks](https://blog.cocoapods.org/CocoaPods-0.36/) in order all symbols to be available at runtime. Shared frameworks are supported on iOS 8+ only, so the iOS deployment target of your app will be upgraded to a minimum of that.
88+
> **NOTE:** Installing CocoaPods sets the deployment target of your app to iOS 8, if not already set to iOS 8 or later. This change is required because CocoaPods are installed as shared frameworks to ensure that all symbols are available at runtime.
8989
9090
## Build the Project
9191

PLUGINS.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ If the NativeScript framework does not expose a native API that you need, you ca
3636

3737
* The plugin must be a valid npm package.
3838
* The plugin must expose a built-in native API or a native API available via custom native libraries.
39-
* The plugin must be written in JavaScript or TypeScript and must comply with the CommonJS specification. If written in TypeScript, make sure to include the compiled JavaScript file in your plugin.
39+
* The plugin must be written in JavaScript and must comply with the CommonJS specification. If you are using a transpiler, make sure to include the transpiled JavaScript files in your plugin.
4040
* The plugin directory structure must comply with the specification described below.
4141
* The plugin must contain a valid `package.json` which complies with the specification described below.
4242
* If the plugin requires any permissions, features or other configuration specifics, it must contain `AndroidManifest.xml` or `Info.plist` file which describe them.
43-
* If the plugin depends on native libraries, it must contain a valid `include.gradle` or `build.xcconfig` file, which describe the dependencies.
43+
* If the plugin depends on native libraries, it must contain a valid `include.gradle` or `build.xcconfig` file, which describes the dependencies.
4444

4545
### Directory Structure
4646

@@ -82,7 +82,7 @@ my-plugin/
8282
* `platforms\android\AndroidManifest.xml`: This file describes any specific configuration changes required for your plugin to work. For example: required permissions. For more information about the format of `AndroidManifest.xml`, see [App Manifest](http://developer.android.com/guide/topics/manifest/manifest-intro.html).<br/>During build, gradle will merge the plugin `AndroidManifest.xml` with the `AndroidManifest.xml` for your project. The NativeScript CLI will not resolve any contradicting or duplicate entries during the merge. After the plugin is installed, you need to manually resolve such issues.
8383
* `platforms\android\include.gradle`: This file modifies the native Android configuration of your NativeScript project such as native dependencies, build types and configurations. For more information about the format of `include.gradle`, see [`include.gradle` file](#includegradle-specification).
8484
* `platforms\android\res`: (Optional) This directory contains resources declared by the `AndroidManifest.xml` file. You can look at the folder structure [here](http://developer.android.com/guide/topics/resources/providing-resources.html#ResourceTypes).
85-
* `platforms\ios\Info.plist`: This file describes any specific configuration changes required for your plugin to work. For example: required permissions. For more information about the format of `Info.plist`, see [About Information Property List Files](https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/AboutInformationPropertyListFiles.html).<br/>During the plugin installation, the NativeScript CLI will merge the plugin `Info.plist` with the `Info.plist` for your project. The NativeScript CLI will not resolve any contradicting or duplicate entries during the merge. After the plugin is installed, you need to manually resolve such issues.
85+
* `platforms\ios\Info.plist`: This file describes any specific configuration changes required for your plugin to work. For example, required permissions. For more information about the format of `Info.plist`, see [About Information Property List Files](https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/AboutInformationPropertyListFiles.html).<br/>During the plugin installation, the NativeScript CLI will merge the plugin `Info.plist` with the `Info.plist` for your project. The NativeScript CLI will not resolve any contradicting or duplicate entries during the merge. After the plugin is installed, you need to manually resolve such issues.
8686
* `platforms\ios\Podfile`: This file describes the dependency to the library that you want to use. For more information, see [CocoaPods.md](CocoaPods.md).
8787
* `platforms\ios\build.xcconfig`: This file modifies the native iOS configuration of your NativeScript project such as native dependencies and configurations. For more information about the format of `build.xcconfig`, see [`build.xcconfig` file](#buildxcconfig-specification).
8888

0 commit comments

Comments
 (0)