Skip to content

Commit cdb1ae1

Browse files
committed
chore: lint and remove only in tests
1 parent df72e93 commit cdb1ae1

File tree

3 files changed

+11
-14
lines changed

3 files changed

+11
-14
lines changed

lib/commands/build.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export abstract class BuildCommandBase extends ValidatePlatformCommandBase {
4949
this.$platformService.copyLastOutput(platform, this.$options.copyTo, buildConfig, this.$projectData);
5050
}
5151

52-
return outputPath
52+
return outputPath;
5353
}
5454

5555
protected validatePlatform(platform: string): void {

test/services/android-project-service.ts

+9-12
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import * as stubs from "../stubs";
44
import { assert } from "chai";
55
import * as sinon from "sinon";
66

7-
8-
97
const createTestInjector = (): IInjector => {
108
const testInjector = new Yok();
119
testInjector.register("androidProjectService", AndroidProjectService);
@@ -21,7 +19,7 @@ const createTestInjector = (): IInjector => {
2119
testInjector.register("androidResourcesMigrationService", {});
2220
testInjector.register("androidPluginBuildService", {});
2321
testInjector.register("filesHashService", {
24-
saveHashesForProject: () => {}
22+
saveHashesForProject: () => ({})
2523
});
2624
testInjector.register("androidPluginBuildService", {});
2725
testInjector.register("errors", stubs.ErrorsStub);
@@ -34,7 +32,7 @@ const createTestInjector = (): IInjector => {
3432
};
3533
},
3634
validateInfo: () => {
37-
35+
return true;
3836
}
3937
});
4038

@@ -50,10 +48,10 @@ const getDefautlBuildConfig = (): IBuildConfig => {
5048
teamId: "",
5149
projectDir: "location/location",
5250
keyStorePath: ""
53-
}
54-
}
51+
};
52+
};
5553

56-
describe.only("androidDebugService", () => {
54+
describe("androidDebugService", () => {
5755
let injector: IInjector;
5856
let androidProjectService: IPlatformProjectService;
5957
let sandbox: sinon.SinonSandbox = null;
@@ -81,7 +79,6 @@ describe.only("androidDebugService", () => {
8179
configurationFilePath: ""
8280
};
8381
});
84-
8582
});
8683

8784
it("release no bundle", async () => {
@@ -93,7 +90,7 @@ describe.only("androidDebugService", () => {
9390

9491
//assert
9592
assert.include(childProcess.lastCommandArgs, "assembleRelease");
96-
})
93+
});
9794

9895
it("debug no bundle", async () => {
9996
//arrange
@@ -105,7 +102,7 @@ describe.only("androidDebugService", () => {
105102

106103
//assert
107104
assert.include(childProcess.lastCommandArgs, "assembleDebug");
108-
})
105+
});
109106

110107
it("release bundle", async () => {
111108
//arrange
@@ -117,7 +114,7 @@ describe.only("androidDebugService", () => {
117114

118115
//assert
119116
assert.include(childProcess.lastCommandArgs, "bundleRelease");
120-
})
117+
});
121118

122119
it("debug bundle", async () => {
123120
//arrange
@@ -130,6 +127,6 @@ describe.only("androidDebugService", () => {
130127

131128
//assert
132129
assert.include(childProcess.lastCommandArgs, "bundleDebug");
133-
})
130+
});
134131
});
135132
});

test/stubs.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -855,7 +855,7 @@ export class AndroidBundleValidatorHelper implements IAndroidBundleValidatorHelp
855855
}
856856

857857
validateRuntimeVersion() {
858-
858+
return;
859859
}
860860
}
861861

0 commit comments

Comments
 (0)